Added support for DELLEMC-OS10-PRODUCTS-MIB (os: dell-os10) #10011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PipoCanaja
added
the
Needs Testing
|
Looks good as far as I can see. Let see the results of the test with the issue submitter. |
|
Looks good from my point of view. |
PipoCanaja
removed
the
Needs Testing
PipoCanaja
approved these changes
Mar 29, 2019
|
Release done, let's merge this. |
spencerbutler
pushed a commit
to spencerbutler/librenms
that referenced
this pull request
May 21, 2019
…#10011) * Added support for DELLEMC-OS10-PRODUCTS-MIB (os: dell-os10) * added info comment * added group: dell
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#9966
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.